Skip to content

Move ContractCard and PublishedBy components to RSC #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Move ContractCard and PublishedBy components to RSC #5097

merged 1 commit into from
Oct 22, 2024
+310 −287

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 21, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring components, improving code organization, and enhancing functionality in the dashboard application. It introduces new features and updates existing ones for better usability and performance.

Detailed summary

  • Added functionSelectors prop to ContractOverviewPage.
  • Refactored toContractIdIpfsHash function to fetchDeployMetadata.
  • Replaced CodeBlock with PlainTextCodeBlock in DeployUpsellCard.
  • Updated ContractCard to use async/await for fetching contract data.
  • Enhanced PublishedBy component to handle ENS resolution asynchronously.
  • Introduced Suspense for loading states in contract cards.
  • Improved structure and readability across various components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9c3ff94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 22, 2024 6:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 22, 2024 6:47pm
wallet-ui ⬜️ Skipped (Inspect) Oct 22, 2024 6:47pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:33 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 21, 2024
@MananTank MananTank mentioned this pull request Oct 21, 2024
Merged
@MananTank MananTank marked this pull request as ready for review October 21, 2024 19:34
@MananTank MananTank marked this pull request as draft October 21, 2024 19:34
@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (45fcfb1) to head (9c3ff94).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5097   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files        1060     1060           
  Lines       54831    54831           
  Branches     3955     3955           
=======================================
  Hits        24832    24832           
  Misses      29308    29308           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 45fcfb1
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from 221e8a6 to e0feaa1 Compare October 21, 2024 19:35
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:35 Inactive
@MananTank MananTank marked this pull request as ready for review October 21, 2024 19:35
@MananTank MananTank force-pushed the 10-22-fix_all_resolvescheme_unhandled_errors branch from 2c7e3f7 to bc5b543 Compare October 21, 2024 19:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (+0.06% 🔺) 857 ms (+0.06% 🔺) 646 ms (+147.53% 🔺) 1.6 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 762 ms (+29.91% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 59 ms (+94.86% 🔺) 156 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 36 ms (+614.96% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 81 ms (-15.03% 🔽) 428 ms

@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from e0feaa1 to 2ae9154 Compare October 21, 2024 19:40
Base automatically changed from 10-22-fix_all_resolvescheme_unhandled_errors to main October 21, 2024 19:40
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:40 Inactive
@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from 2ae9154 to 01bb690 Compare October 21, 2024 19:47
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 17:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 17:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 17:32 Inactive
@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from 5633a41 to 4ca5f74 Compare October 22, 2024 17:45
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 17:45 Inactive
@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from 4ca5f74 to b3827b8 Compare October 22, 2024 18:03
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:03 Inactive
@MananTank MananTank marked this pull request as ready for review October 22, 2024 18:13
@MananTank MananTank mentioned this pull request Oct 22, 2024
Closed
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024 •
edited
Loading

Merge activity

@MananTank MananTank force-pushed the 10-22-move__explore_page_to_rscs branch from b3827b8 to 9c3ff94 Compare October 22, 2024 18:44
@graphite-app graphite-app bot merged commit 9c3ff94 into main Oct 22, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-22-move__explore_page_to_rscs branch October 22, 2024 18:48
@vercel vercel bot temporarily deployed to Production – docs-v2 October 22, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 22, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 22, 2024 18:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls